rsync - Mar 2011 - DO NOT REPLY [Bug 7981] New: fix for fileflags.diff compile error w/3.0.8pre1

https://bugzilla.samba.org/show_bug.cgi?id=7981

           Summary: fix for fileflags.diff compile error w/3.0.8pre1
           Product: rsync
           Version: 3.0.8
          Platform: Other
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: marcin.cieslak at gmail.com
         QAContact: rsync-qa at samba.org


Trying to compile for FreeBSD:

cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c rsync.c -o rsync.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c generator.c -o
generator.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c receiver.c -o
receiver.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c cleanup.c -o
cleanup.occ -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c rsync.c -o rsync.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c generator.c -o
generator.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c receiver.c -o
receiver.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c cleanup.c -o
cleanup.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c sender.c -o sender.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c exclude.c -o
exclude.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c util.c -o util.o
util.c: In function 'try_a_force_change':
util.c:141: error: 'ret' undeclared (first use in this function)
util.c:141: error: (Each undeclared identifier is reported only once
util.c:141: error: for each function it appears in.)
*** Error code 1

cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c sender.c -o sender.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c exclude.c -o
exclude.o
cc -std=gnu99 -I. -I. -O2 -pipe -march=nocona -I/usr/local/include
-fno-strict-aliasing -DHAVE_CONFIG_H -Wall -W -I./popt  -c util.c -o util.o
util.c: In function 'try_a_force_change':
util.c:141: error: 'ret' undeclared (first use in this function)
util.c:141: error: (Each undeclared identifier is reported only once
util.c:141: error: for each function it appears in.)
*** Error code 1

Trivial fix follows, although I think this code should be reviewed.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7981





------- Comment #1 from marcin.cieslak at gmail.com  2011-03-02 10:05 CST
-------
Created an attachment (id=6275)
 --> (https://bugzilla.samba.org/attachment.cgi?id=6275&action=view)
trivial fix


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7981


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned at samba.org  2011-03-02 19:55 CST -------
Thanks.  Fixed in the git repo.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.