rsync - Jun 2011 - [Bug 8266] New: fileflags.diff compile fix

https://bugzilla.samba.org/show_bug.cgi?id=8266

           Summary: fileflags.diff compile fix
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: chris at onthe.net.au
         QAContact: rsync-qa at samba.org


As of commit 6e056167 fileflags.diff produces a compile error. The attached
patch fixes this.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8266

--- Comment #1 from Chris Dunlop <chris at onthe.net.au> 2011-06-25
14:14:38 UTC ---
Created attachment 6624
  --> https://bugzilla.samba.org/attachment.cgi?id=6624
Fix for fileflags.diff

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8266

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Wayne Davison <wayned at samba.org> 2011-06-25
16:04:44 UTC ---
The return from try_a_force_change() was also wrong in that code path, so I
fixed that too.

Note that it is always nice to generate a patch on the files themselves, not a
patch of a patch.  Patch files are auto-generated.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8266

--- Comment #3 from Chris Dunlop <chris at onthe.net.au> 2011-06-27
05:52:54 UTC ---
In gmane.network.rsync.general, Wayne Davison wrote:
> Note that it is always nice to generate a patch on the files themselves,
not a
> patch of a patch.  Patch files are auto-generated.
No worries.

Out of interest, what form is the original form from which the patch
files are auto-generated, e.g. git branches?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=8266

--- Comment #4 from Wayne Davison <wayned at samba.org> 2011-06-28
06:03:03 UTC ---
(In reply to comment #3)
> Out of interest, what form is the original form from which the patch
> files are auto-generated, e.g. git branches?
Yup -- see packaging/branch-from-patch script (on the master branch).  Patches
are updated via packaging/patch-update script from my local branches.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.