rsync - Jul 2018 - [Bug 13522] New: Patch fileflags.diff and crtimes.diff

https://bugzilla.samba.org/show_bug.cgi?id=13522

            Bug ID: 13522
           Summary: Patch fileflags.diff and crtimes.diff
           Product: rsync
           Version: 3.1.3
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: bugzilla.samba.org-prf at jf-luce.name
        QA Contact: rsync-qa at samba.org

rsync won't compile anymore after applying these 2 patches.

Error:  too few arguments to function call, expected 4, have 2
File : rsync.c
Line : 614 :   for if (cmp_time(sxp->crtime, file_crtime) != 0

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=13522

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Wayne Davison <wayned at samba.org> ---
I fixed the patches git repo to have the right cmp_time() calls. I did not test
the resulting patch, though, since I don't have an appropriate computer to
try
it out on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=13522

--- Comment #2 from jief <bugzilla.samba.org-prf at jf-luce.name> ---
Hi,

I can compile it and use it (I use rsync almost every day). I'm not saying
it'll comprehensive tests will all use cases possible, but it'll be some
tests.

But where can I get the source. Can only see the tar ball of 3.1.3 on home
page. Is the git public ?

I guess it is reasonably safe to use the current git version. Or is it a work
in progress and I should wait for a release ?

Thanks.
Jief

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=13522

--- Comment #3 from Wayne Davison <wayned at samba.org> ---
The download page mentions all of the ways to grab the source, including git:

https://rsync.samba.org/download.html

The git source is safe, as it only contains bug fixes since the last release.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=13522

jief <bugzilla.samba.org-prf at jf-luce.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from jief <bugzilla.samba.org-prf at jf-luce.name> ---
I got the same error.
In the patch crtimes.diff, downloaded here :
https://git.samba.org/?p=rsync-patches.git;a=blob;f=crtimes.diff;h=178ae05ff854b57fe36e91c938b2959c3a0ed963;hb=master,
the line "if (cmp_time(sxp->crtime, file_crtime) != 0" is still
there.

Did I downloaded crtimes.diff from the right place ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=13522

Wayne Davison <wayne at opencoder.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Wayne Davison <wayne at opencoder.net> ---
My apologies -- I had committed that change on an different computer and failed
to push it to the public repository.  I just found the old commit and pushed it
out.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.