rsync - May 2014 - [Bug 10611] New: No error code returned when removing source file failed

https://bugzilla.samba.org/show_bug.cgi?id=10611

           Summary: No error code returned when removing source file
                    failed
           Product: rsync
           Version: 3.1.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: peto2468 at hotmail.com
         QAContact: rsync-qa at samba.org


Created attachment 9945
  --> https://bugzilla.samba.org/attachment.cgi?id=9945
Patch for returning error 26, when removing source files failed.

When rsync is required to remove source files with --remove-source-files option
and source files where not removed (eg. due to missing write permission on
source dir), no error code is returned, only error message is logged:
rsync: sender failed to remove [file]: Permission denied (13)

One would expect, that user is notified by special error code, that files were
tranferred succesfully, but source files were not removed as desired.

I created a small patch to fix this (see attachment).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=10611

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Wayne Davison <wayned at samba.org> 2014-05-25
23:02:03 UTC ---
I'm making rsync exit with the standard partial-transfer error code (which
always means that someone needs to check the error messages to see what
actually went wrong).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.