rsync - Jul 2005 - [Bug 2868] Allow fifos to be copied by normal users

https://bugzilla.samba.org/show_bug.cgi?id=2868





------- Additional Comments From rsync@cpe-24-95-91-210.columbus.res.rr.com 
2005-07-23 23:36 -------
this should apply to both fifos and sockets.
creation of both are unprivileged operations,
see mkfifo(2), socket(2)/bind(2) on freebsd.
suggest moving/modifying do_mknod in these sections
 backup.c
 generator.c
to run regardles of uid and simply complain and continue
on platforms where those syscalls are restricted. just
like if a regular file can't be read due to perm/uid:
 rsync: send_files failed to open "/tmp/a.out": Permission denied (13)

any other eyes looking at this feature may wish to see related:
 http://lists.samba.org/archive/rsync/2003-October/007555.html
 http://lists.samba.org/archive/rsync/2002-June/002966.html
 http://www.mail-archive.com/rsync@lists.samba.org/msg00477.html

reply to bugzilla/samba list only, thx.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2868





------- Additional Comments From noreply@cpe-24-95-90-2.columbus.res.rr.com 
2005-08-04 22:01 -------
Created an attachment (id=1356)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1356&action=view)
patch, tweak to taste per comment

allow nonroot to try do_mknod() for fifo/sock/block/char. if block/char failed
due to nonroot perm denied [EPERM] in mknod(2):
 without -v, continue quietly, exit 0
 with -v, continue verbosely, exit 0
printing for both is the official pre-patch behavior, so the user may wish to
extend non-v with rsyserr(FINFO...) to match. actually, do_mknod's mknod()
should be wrapped with similar if and rsyserr 'skipping' statements
before call
instead. applies to: cvs -D '2005-08-02 00:00:00-0000'. a little give
back
against the debt, enjoy;-]

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2868





------- Additional Comments From wayned@samba.org  2005-09-03 09:49 -------
Created an attachment (id=1412)
 --> (https://bugzilla.samba.org/attachment.cgi?id=1412&action=view)
Make special files copyable by non-root

This patch divides what rsync considered "devices" into devices and
specials,
making it possible to control the copying of each category via options.  For
full compatibility when copying to/from an older rsync, the -D option still
means "copy device-files and special-files".  Also, the -a option
still turns
on the copying of both categories of files.  However, since specials are now
copied by non-root, this means that a user would need to specify "-a
--no-specials" to turn this off (or "-a --no-D" as a non-root
user would also
do the same thing).  Note that the --devices option now turns on just the
copying of devices, so the user should use -D or "--devices
--specials" for
both.  Finally, itemized output was extended to output special files with the
letter "s" (separating them from devices, which output with the letter
"D").

Comments?

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.