rsync - Aug 2004 - [Bug 1582] rsync dry run cannot find missing folders, contradicts actual run.

https://bugzilla.samba.org/show_bug.cgi?id=1582





------- Additional Comments From wayned@samba.org  2004-08-05 11:21 -------
Created an attachment (id=594)
 --> (https://bugzilla.samba.org/attachment.cgi?id=594&action=view)
Fix problem with --dry-run (-n)

This patch avoids a fatal error when using --dry-run and the destination
directory does not exist on the receiver.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1582


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2004-08-05 11:23 -------
The fix was checked into CVS.
> I hope this report has been satisfactory.
The report was very well done.  Thanks!

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1582





------- Additional Comments From weyerse@sgi.com  2004-08-05 13:27 -------
There appears to be a problem in that my generator.c differs from your
generator.c enough that the patch can not find and patch the correct area.  The
area the patch looks like it's trying to correct on my version looks like
this:

	if (list_only)
		return;

	if (verbose > 2)
		rprintf(FINFO,"recv_generator(%s,%d)\n",fname,i);

	statret = link_stat(fname,&st);

	if (only_existing && statret == -1 && errno == ENOENT) {
		/* we only want to update existing files */

This is different from what I have.  Otherwise the pach worked well on main.c so
there is no need to worry about that.  Are there other patches you have used on
generator.c in the past that I need to be aware of?  

Otherwise thank you for looking into this bug.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1582





------- Additional Comments From wayned@samba.org  2004-08-05 14:31 -------
(In reply to comment #3)
> Are there other patches you have used on generator.c in the past
> that I need to be aware of?
All the patches I post to bugzilla are relative to the CVS version, so it's
not
surprising that you ran into a problem if you tried to patch an earlier release.
You can either snag the CVS version (for instance, the latest nightly tar file
from the rsync website has the fix already applied).  Or you can adapt the fix
for your version.
>From the code you cited, here's how I would adapt the fix:
	if (verbose > 2)
		rprintf(FINFO,"recv_generator(%s,%d)\n",fname,i);

	if (dry_run > 1) {
		statret = -1;
		errno = ENOENT;
	} else
		statret = link_stat(fname,&st);

	if (only_existing && statret == -1 && errno == ENOENT) {
		/* we only want to update existing files */

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1582





------- Additional Comments From weyerse@sgi.com  2004-08-06 07:34 -------
Thank you very much for your help.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.